[SYCL]refactor pad_reflect_1d to make the UT case pass #17204
+115
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
Contributor
|
looks good |
airMeng
approved these changes
Nov 20, 2025
arthw
approved these changes
Nov 21, 2025
NeoZhangJianyu
requested review from
Rbiessy,
ggerganov and
slaren
and removed request for
ggerganov
Collaborator
Author
|
@ggerganov @slaren @Rbiessy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of pad_reflect_1d can't pass in CI UT.
Refactor pad_reflect_1d to make the UT case pass.